Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust sbottom region A regression test tolerance for GHA runner change #1364

Merged
merged 8 commits into from
Mar 18, 2021
Merged

fix: Adjust sbottom region A regression test tolerance for GHA runner change #1364

merged 8 commits into from
Mar 18, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 18, 2021 •
edited
Loading

Description

Resolves #1362

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Modify the tolerance of the sbottom Region A regression test to pass after GitHub Action runner change
   - Change is needed for only one expected CLs value

@matthewfeickert matthewfeickert added the fix A bug fix label Mar 18, 2021
@matthewfeickert matthewfeickert self-assigned this Mar 18, 2021
@matthewfeickert
Copy link
Member Author

Things are currently failing due to problems with jaxlib v0.1.63 and jax v0.2.10 on MacOS runners. jaxlib v0.1.63 was released today (2021-03-17) so I'll file an Issue for it with the JAX team.

@matthewfeickert
Copy link
Member Author

The good news is that the failure for the Mac runners is being caused by a broken wheel upload to PyPI and should be fixed within 24 hours.

@matthewfeickert matthewfeickert changed the title fix: Adjust sbottom region A regression test for GHA runner change fix: Adjust sbottom region A regression test tolerance for GHA runner change Mar 18, 2021
@matthewfeickert matthewfeickert mentioned this pull request Mar 18, 2021
Open
@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #1364 (ff76559) into master (2fbc4bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1364   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          63       63           
  Lines        3768     3768           
  Branches      538      538           
=======================================
  Hits         3674     3674           
  Misses         55       55           
  Partials       39       39
Flag Coverage Δ
unittests 97.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb877b8...ff76559. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 966742c into master Mar 18, 2021
@matthewfeickert matthewfeickert deleted the fix/unbreak-ci branch March 18, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratsg kratsg kratsg approved these changes

@lukasheinrich lukasheinrich Awaiting requested review from lukasheinrich

Assignees

@matthewfeickert matthewfeickert

Labels
fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in sbottom regression tests
2 participants
@matthewfeickert @kratsg